RFR: 8310332: Fix -Wconversion warnings in MethodData [v3]

Coleen Phillimore coleenp at openjdk.org
Wed Jun 21 12:11:08 UTC 2023


> Please review this change to narrow parameter and return types to avoid implicit casts, add casts where obvious, add checked_cast<> where not obvious and changed the size of a couple parameters to not cast to the smaller size.
> I didn't change TypeProfileWidth and BciProfileWidth because jvmci and SA care about the sizes.
> Tested tier1 all Oracle supported platforms, and tier1-4 linux + windows x64.

Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into md-conversion
 - Add a checked_cast<>
 - Fix -Wconversion warnings in methodData

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14557/files
  - new: https://git.openjdk.org/jdk/pull/14557/files/594e617d..29bf2bd4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14557&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14557&range=01-02

  Stats: 9256 lines in 356 files changed: 4908 ins; 1858 del; 2490 mod
  Patch: https://git.openjdk.org/jdk/pull/14557.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14557/head:pull/14557

PR: https://git.openjdk.org/jdk/pull/14557


More information about the hotspot-dev mailing list