RFR: 8310577: Fix -Wconversion warnings in interpreter and oops [v2]

Coleen Phillimore coleenp at openjdk.org
Thu Jun 22 16:01:07 UTC 2023


On Thu, 22 Jun 2023 15:47:00 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fred's suggestion.
>
> src/hotspot/share/interpreter/bytecodes.cpp line 443:
> 
>> 441: #endif
>> 442:   jchar bc_flags = 0;
>> 443:   if (can_trap)           bc_flags |= _bc_can_trap;
> 
> I believe that bitwise-or will promote the operands to int. Will this cause any issues here?

Since _bc_can_trap is also a jchar, it doesn't promote to int (I have a test cpp file to verify this).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14604#discussion_r1238735931


More information about the hotspot-dev mailing list