RFR: 8309140: ResourceHashtable failed "assert(~(_allocation_t[0] | allocation_mask) == (uintptr_t)this) failed: lost resource object"

[Coleen Phillimore]

On Wed, 21 Jun 2023 17:49:10 GMT, Justin Gu <duke at openjdk.org> wrote:

> Please review the change to ResourceHashtables from statically allocated to CHeap allocated at initialization time. Ran Mach5 testing tiers 1-4 that all passed. See CR for more details.

This looks good! I have a couple of comments to fix.

src/hotspot/share/classfile/verifier.cpp line 618:

> 616: }
> 617: 
> 618: 

This line should be removed (extraneous change).

src/hotspot/share/runtime/sharedRuntime.cpp line 2708:

> 2706:   AdapterBlob* obj_obj_arg_blob = nullptr;
> 2707:   {
> 2708:     _adapter_handler_table = new (mtClass) AHTable();

This should be mtCode not mtClass since the adapter_handler_table belongs to the mtCode (NMT code tracking category).

-------------

Changes requested by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14601#pullrequestreview-1493648298
PR Review Comment: https://git.openjdk.org/jdk/pull/14601#discussion_r1238802229
PR Review Comment: https://git.openjdk.org/jdk/pull/14601#discussion_r1238804881