RFR: JDK-8310510: WordsPerLong is wrong for 64-bit platforms
Martin Doerr
mdoerr at openjdk.org
Thu Jun 22 18:24:02 UTC 2023
On Wed, 21 Jun 2023 08:08:44 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> Trivial patch.
>
> We have WordsPerLong defined as this:
>
>
> const int WordsPerLong = 2; // Number of stack entries for longs
>
>
> which is wrong for 64-bit platforms. Historically used only for ppc/s390.
>
> Patch removes the unnecessary align (BasicLock is always 2 words, no need to align to 2) and removes WordsPerLong, since it is not needed anymore.
It isn't wrong in terms of code correctness, but it may be misleading. So, I appreciate the removal.
Maybe the title should better just say "Remove WordsPerLong"?
-------------
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14580#pullrequestreview-1493771522
PR Comment: https://git.openjdk.org/jdk/pull/14580#issuecomment-1603120853
More information about the hotspot-dev
mailing list