RFR: 8310606: Fix signed integer overflow, part 3
Andrew Haley
aph at openjdk.org
Fri Jun 23 17:40:05 UTC 2023
On Thu, 22 Jun 2023 19:53:19 GMT, Dean Long <dlong at openjdk.org> wrote:
> Most of these changes are straight-forward, but these could use some explaining:
>
> AllocatePrefetchDistance was accessed before it's dynamic constraint function got run. I changed it to use static constraints.
>
> RangeCheckEliminator::update_bound(): for constant bounds with meaningless values, bail out. For X + c bounds, use Java wrap-around semantics.
src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 84:
> 82: // constraint.
> 83: if (FLAG_IS_DEFAULT(AllocatePrefetchDistance))
> 84: FLAG_SET_DEFAULT(AllocatePrefetchDistance, MIN2(512, 3*dcache_line));
Looks reasonable enough, but I think the magic constant 512 deserves a comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14619#discussion_r1240099501
More information about the hotspot-dev
mailing list