RFR: 8310494: Do not include constantPool.hpp from instanceKlass.hpp [v3]
Coleen Phillimore
coleenp at openjdk.org
Fri Jun 23 18:06:03 UTC 2023
On Thu, 22 Jun 2023 22:38:12 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> instanceKlass.hpp is needed quite frequently for HotSpot C++ sources, but constantPool.hpp is much less frequently.
>>
>> This PR is the first step of reducing the inclusion of constantPool.hpp, by removing it from instanceKlass.hpp
>>
>> I moved a bunch of inline functions into instanceKlass.cpp. These don't seem to be performance related.
>
> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'master' into 8310494-remove-constantPool-from-instanceKlass-hpp
> - moved comment about on_stack() to the cpp file (which already has the comment)
> - @stefank review comments
> - 8310494: Do not include constantPool.hpp from instanceKlass.hpp
Marked as reviewed by coleenp (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/14597#pullrequestreview-1495644882
More information about the hotspot-dev
mailing list