RFR: 8301996: Move field resolution information out of the cpCache

Amit Kumar amitkumar at openjdk.org
Sat Jun 24 06:01:20 UTC 2023


On Wed, 24 May 2023 16:55:47 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> 8301996: Move field resolution information out of the cpCache

src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 1893:

> 1891:   } else {
> 1892:     mov(cache, sizeof(ResolvedFieldEntry));
> 1893:     mul(index, index, cache); // Scale the index to be the entry index * sizeof(ResolvedInvokeDynamicInfo)

A few cosmetic suggestions: 

Suggestion:

    mul(index, index, cache); // Scale the index to be the entry index * sizeof(ResolvedFieldEntryInfo)


you might want to update this comment in x86 file as well ;-) 

Beside this I guess you should update header-year for `src/hotspot/share/ci/ciStreams.cpp` , `src/hotspot/share/interpreter/interpreterRuntime.hpp` , `test/hotspot/gtest/oops/test_cpCache_output.cpp`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1240614054


More information about the hotspot-dev mailing list