RFR: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic

Fei Yang fyang at openjdk.org
Mon Jun 26 08:38:03 UTC 2023


On Mon, 26 Jun 2023 05:06:20 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

> The compare_short ( in c2_macroAssember) was doing too much conditional branches in one place,it was possible to slightly reduce it. Thanks for looking at it.

I haven't checked other changes, but for the possible unaligned accesses in file src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp:
https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp#LL958-L971

It looks that simple calls to load_X_misaligned assemblers with proper granularity will suffice, which would be much simpler.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14534#issuecomment-1606973705


More information about the hotspot-dev mailing list