RFR: 8309140: ResourceHashtable failed "assert(~(_allocation_t[0] | allocation_mask) == (uintptr_t)this) failed: lost resource object" [v2]

[Matias Saavedra Silva]

On Mon, 26 Jun 2023 14:03:29 GMT, Justin Gu <duke at openjdk.org> wrote:

>> Please review the change to ResourceHashtables from statically allocated to CHeap allocated at initialization time. Ran Mach5 testing tiers 1-4 that all passed. See CR for more details.
>
> Justin Gu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed reviews

Overall, this looks good! I just have one comment

src/hotspot/share/classfile/loaderConstraints.cpp line 112:

> 110: 
> 111: 
> 112: using LCTable = ResourceHashtable<SymbolHandle, ConstraintSet, 107, AnyObj::C_HEAP, mtClass, SymbolHandle::compute_hash>;

While `LCTable` is a concise name, it might be too short to properly indicate what it's for. I think all of the new tables should either have a full written-out name like `InvokeMethodIntrisicTable` or they should have comments describing what they are for.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14601#pullrequestreview-1498759740
PR Review Comment: https://git.openjdk.org/jdk/pull/14601#discussion_r1242338575