RFR: 8310656: RISC-V: __builtin___clear_cache can fail silently.

[Ludovic Henry]

On Tue, 27 Jun 2023 12:42:53 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> During boot we want to give the user an informative message of what is wrong and not crash.
>> Calling RiscvFlushIcache::flush() brings the vm down hard, so we can't call that.
>> So the only options would be to expose the syscall and it's defines, which I don't want to.
>> Hence a separate method was done.
>
> Note that reason why I bring down the VM is because if we are executing old instructions, anything can happen.
> And it can go unnoticed for very long, by bring the VM down directly the user will not get unwanted consequences and have a chance to do a failover before anything bad happens.

I'm fine with another method, I mean what's the need for a different class and file?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14670#discussion_r1243703862