RFR: 8310921: Fix -Wconversion warnings from GenerateOopMap [v2]
David Holmes
dholmes at openjdk.org
Tue Jun 27 23:34:07 UTC 2023
On Tue, 27 Jun 2023 13:20:21 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> This is broken out from but tested with the PR from https://github.com/openjdk/jdk/pull/14659
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> David Holmes comments
src/hotspot/share/oops/generateOopMap.cpp line 2060:
> 2058: tty->print_cr (" Total : %3.3f sec.", GenerateOopMap::_total_oopmap_time.seconds());
> 2059: tty->print_cr (" (%3.0f bytecodes per sec) ",
> 2060: (double)GenerateOopMap::_total_byte_count / GenerateOopMap::_total_oopmap_time.seconds());
I still don't see a need for the double cast here - the normal numeric promotion rules will make the expression a double. What error is reported for this code?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14666#discussion_r1244479203
More information about the hotspot-dev
mailing list