RFR: 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit [v4]

Doug Simon dnsimon at openjdk.org
Wed Jun 28 07:26:07 UTC 2023


On Tue, 27 Jun 2023 23:06:49 GMT, Tom Rodriguez <never at openjdk.org> wrote:

> I don't think pushing it down that far improves things. encode always precedes decode so why not resolve it before the encode call.

Because the `VMSupport` klass is only needed if calling into HotSpot so it's better to push it down into `HotSpotToSharedLibraryExceptionTranslation::encode`. Also, if the `VMSupport` klass is used for encoding, it's *not* needed for decoding (the libgraal `VMSupport` jclass value is used instead).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14641#issuecomment-1610903263


More information about the hotspot-dev mailing list