RFR: 8310949: RISC-V: Initialize UseUnalignedAccesses [v3]
Ludovic Henry
luhenry at openjdk.org
Wed Jun 28 08:36:04 UTC 2023
On Wed, 28 Jun 2023 08:32:26 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Ludovic Henry has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fixup! 8310949: RISC-V: Initialize UseUnalignedAccesses
>
> Hey, there is a block before this in the same file:
>
>
> if (FLAG_IS_DEFAULT(AvoidUnalignedAccesses)) {
> if (unaligned_access.value() != MISALIGNED_FAST) {
> FLAG_SET_DEFAULT(AvoidUnalignedAccesses, true);
> } else {
> FLAG_SET_DEFAULT(AvoidUnalignedAccesses, false);
> }
> }
>
>
> ...which needs to be reconciled with this one? At very least, it shows that it is possible to sense `MISALIGNED_FAST`.
@shipilev sounds good! Let's only enable `UseUnalignedAccesses` on platform that support fast unaligned accesses. We should use `unaligned_access.value() == MISALIGNED_FAST` to set it up IMO.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14676#issuecomment-1610996609
More information about the hotspot-dev
mailing list