RFR: 8310110: Shenandoah: Trace page sizes [v5]

[Thomas Stuefe]

On Wed, 28 Jun 2023 09:05:31 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - remove test changes from patch
>>  - Merge branch 'master' into JDK-8310110-Trace-page-sizes
>>  - remove Shenandoah from TestTracePageSizes
>>  - disable Shenandoah THP trace test for now
>>  - reformat
>>  - enable runtime/os/TestTracePageSizes.java for shenandoah
>>  - feedback aleksey
>>  - Merge branch 'master' into JDK-8310110-Trace-page-sizes
>>  - JDK-8310110-Trace-page-sizes
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 332:
> 
>> 330:         assert(cset_rs.base() == req_addr, "Allocated where requested: " PTR_FORMAT ", " PTR_FORMAT, p2i(cset_rs.base()), addr);
>> 331:         _collection_set = new ShenandoahCollectionSet(this, cset_rs, sh_rs.base());
>> 332:         rs = &cset_rs;
> 
> I'm probably missing something here, but doesn't cset_rs go out of scope, and rs would point to undefined stuff?

:-( you are of course right. This only worked out of accident since ReservedSpace has no dtor.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14486#discussion_r1244937097