RFR: 8310110: Shenandoah: Trace page sizes [v5]

Thomas Stuefe stuefe at openjdk.org
Wed Jun 28 09:39:13 UTC 2023


On Wed, 28 Jun 2023 09:23:33 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>>> :-( you are of course right. This only worked out of accident since ReservedSpace has no dtor.
>> 
>> Could you copy-assign the object, instead?
>
> Or just null-check the resulting `_collection_set` and print the message then. Don't need to mess with locals then?

Okay, fixed. Copying ReservedSpace is fine, we do it in other places too. This thing is used like a value object in most places.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14486#discussion_r1244950238


More information about the hotspot-dev mailing list