RFR: 8311064: Windows builds fail without precompiled headers after JDK-8310728

Daniel Jeliński djelinski at openjdk.org
Wed Jun 28 21:25:08 UTC 2023


Please review this change to fix Windows build without precompiled headers.

After JDK-8310728:
> the compiler enforces the C++11 requirement that all functions declared inline must have a definition available in the same translation unit if they're used

When precompiled headers are used, more headers are automatically included, which allowed the build to pass without this change.

This PR adds 2 includes and un-inlines `PlatformMutex` destructor, which was needed by 3 files and not easily exposed.

Windows build passes with this change, both with and without precompiled headers. Full tier1-5 build in progress.

-------------

Commit messages:
 - Add missing includes after zc:inline

Changes: https://git.openjdk.org/jdk/pull/14701/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14701&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8311064
  Stats: 10 lines in 4 files changed: 5 ins; 4 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14701.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14701/head:pull/14701

PR: https://git.openjdk.org/jdk/pull/14701


More information about the hotspot-dev mailing list