RFR: 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit [v5]

David Holmes dholmes at openjdk.org
Thu Jun 29 02:15:55 UTC 2023


On Wed, 28 Jun 2023 21:21:11 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> The VMSupport class is required for translating an exception between the HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception being translated.
>> To avoid this, VMSupport is loaded eagerly along with the other vmClasses.
>
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   [skip ci] handle pending HotSpot exception closer to site causing exception

This is now isolated to JVMCI code that I'm not familiar with, so don't feel competent to review. The general idea seems okay but I'm not familiar enough with the details. Someone from the compiler team should review this now.

Thanks.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14641#pullrequestreview-1504459576


More information about the hotspot-dev mailing list