RFR: JDK-8308994: C2: Re-implement experimental post loop vectorization

[Emanuel Peter]

On Thu, 29 Jun 2023 09:28:20 GMT, Pengfei Li <pli at openjdk.org> wrote:

>> I'm in the middle of reviewing, but have to end it here for the week now 😊 
>> 
>> For now it's a lot of detail-feedback. I'll give a more overall-feedback once I'm done reading through, and reflecting on it.
>> 
>> Still: this is good work. We will have to discuss the performance benefits vs the code complexity. And maybe we first need to refactor some things to reduce code duplication. But this looks much better than the previous post-loop vectorization.
>> 
>> Have a great weekend,
>> Emanuel
>
> Hi @eme64,
> 
> I guess you have done your first round of review. @fg1417 and I really appreciate all your constructive inputs. By reading your comments, I believe you have reviewed this patch in very detail. Thanks again!
> 
> What I am doing now:
> 
> - I'm trying to fix the issues which I think can be fixed immediately.
> - I'm trying to answer all your simple questions ASAP.
> 
> For your request of big refactoring work, I feel like I personally may not have enough time and capability to complete it in a short time. We may need some discussion about it. But it's great to know more about your "hybrid vectorizer" plan from your feedback. It looks like a grand plan, and requires significant effort and cooperation. I strongly agree that we need some conversation to discuss where we should move forward and what we can cooperate. Could you give us a moment to digest your idea before we schedule a conversation?
> 
> BTW: What's your preferred time for a conversation? We are based in Shanghai (GMT+8)

Hi @pfustc !

I'm grad you appreciate my review.

> For your request of big refactoring work, I feel like I personally may not have enough time and capability to complete it in a short time.

Are you under some time constraint? No pressure from my side, take the time you need.

I would very much love to have a conversation over a video call with you. I think that would be beneficial for all of us. The problem from our side (Oracle) are intellectual property concerns. OpenJDK emails and PR's are all under the Oracle Contributor Agreement. So there I'm free to have conversations. I'm trying to figure out if we can have a similar frame for a video call, sadly it may take a few weeks or months to get that sorted, as many people are on summer vacation.

Please take some time to digest the feedback. This is a big change set, it will take a while to be ready for integration at any rate. And again, I would really urge you to consider some refactoring of SuperWord in a separate RFE before this change here.

I'm looking forward to more collaboration - over PR comments, emails, and hopefully eventually video calls as well 😃 
Emanuel

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14581#issuecomment-1612877985