RFR: 8311064: Windows builds fail without precompiled headers after JDK-8310728

[Stefan Karlsson]

On Fri, 30 Jun 2023 01:24:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

> > > certainly suggests to me that zPhysicalMemory.cpp needs the ZListNode header file.
> > 
> > 
> > How do you know that it isn't one of the include .inline.hpp files that needs the ZListNode destructor?
> 
> I don't know for certain but in the context of reviewing these changes the code change was not obviously incorrect in relation to the error message.

Right, the change works, but it adds an include in a file that doesn't explicitly use that included functions. That shows that there is an issues somewhere else that we will likely show up to be a problem in the future. We've now identified that the issues is that zMemory.hpp has a dependency against the destructor in zList.inline.hpp. We'll deal with that a new RFE.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14701#issuecomment-1614295181