RFR: 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit [v6]
Doug Simon
dnsimon at openjdk.org
Fri Jun 30 14:40:09 UTC 2023
On Thu, 29 Jun 2023 20:06:19 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> The VMSupport class is required for translating an exception between the HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception being translated.
>> To avoid this, VMSupport is loaded eagerly along with the other vmClasses.
>
> Doug Simon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - [skip ci] Merge remote-tracking branch 'openjdk-jdk/master' into JDK-8310829
> - [skip ci] handle pending HotSpot exception closer to site causing exception
> - revert to lazy loading of VMSupport
> - each exception translation failure should trigger a JVMCI event
> - try harder to show nested exception during exception translation
> - resolve VMSupport at bootstrap to avoid nested exception in ExceptionTranslation::doit
I have fixed the warning on Windows: 5bb3b529d36c906ac861e5ebf1b861dbb35bfe2c
> But, please, activate GHA testing for this branch.
Isn't GHA a strict subset of or equal to tier1 mach5 testing? If so, what's the point of doing redundant testing?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14641#issuecomment-1614746764
More information about the hotspot-dev
mailing list