RFR: 8193513: add support for printing a stack trace on class loading [v2]

[Doug Simon]

On Fri, 30 Jun 2023 01:09:30 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> These are all good suggestions and feedback. I'll need some help wrt using UL macros. Firstly, how do I expand upon:
>> 
>>   if (!log_is_enabled(Info, class, load)) {
>>     return;
>>   }
>> 
>> to also support `-Xlog:class+load+cause`, `-Xlog:class+load+cause+native` and `-Xlog:class+load+cause*`?
>
> if (log_is_enabled(Info, class, load, cause)) {
>   doStuff();
> }
> 
> HTH

Are you saying `log_is_enabled(Info, class, load, cause)` implies `log_is_enabled(Info, class, load)`?
Or do I need:

  if (!log_is_enabled(Info, class, load) && !log_is_enabled(Info, class, load, cause)) {
    return;
  }

to extend the check on [line 3793](https://github.com/openjdk/jdk/blob/e8ff74c7e84ec2440a51fee1b4c45e87332807a0/src/hotspot/share/oops/instanceKlass.cpp#L3793)?

I don't understand the relationship between `class+load+cause` and `class+load` and the comment on `log_is_enabled` doesn't help much.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14553#discussion_r1248110339