RFR: JDK-8302989: Add missing INCLUDE_CDS checks [v2]
Matthias Baesken
mbaesken at openjdk.org
Wed Mar 1 11:30:02 UTC 2023
On Wed, 1 Mar 2023 09:57:28 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Make SharedSpaces related vars const and false in non CDS mode
>
> src/hotspot/share/utilities/globalDefinitions.hpp line 594:
>
>> 592: #else
>> 593: // in non CDS mode do not export it
>> 594: extern const bool UseSharedSpaces;
>
> How about this?
>
>
> const bool RequireSharedSpaces = false;
>
>
> This will allow the C++ compiler to eliminate all code that depend on this value when `INCLUDE_CDS` is false.
Hi Ioi, I set this already some lines above (in the non-INCLUDE_CDS case).
-------------
PR: https://git.openjdk.org/jdk/pull/12691
More information about the hotspot-dev
mailing list