RFR: 8303418: Improve parameter and variable names in BitMap [v2]
Thomas Schatzl
tschatzl at openjdk.org
Wed Mar 1 11:38:14 UTC 2023
On Wed, 1 Mar 2023 06:08:33 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Please review this change to names in BitMap.
>>
>> - Parameters that designate a bit in a BitMap are named "bit".
>> - Parameters that designate a word in the underlying BitMap storage are named "word".
>> - Parameters that designate a range are named "beg" and "end" resp.
>>
>> Added helper function `flipped_word` for use by `get_next_bit_impl`, replacing
>> the odd overload for `map`.
>>
>> In `get_next_bit_impl`, prefixed the variables "index" and "limit" with
>> "word_" to make clear the units.
>>
>> Testing:
>> mach5 tier1
>
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>
> copyrights
Lgtm.
It would be great to also fix the unusual spacing between method names and the parameter brackets (and the method body brackets) a little, but that can be a different issue.
-------------
Marked as reviewed by tschatzl (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12798
More information about the hotspot-dev
mailing list