RFR: 8302191: Performance degradation for float/double modulo on Linux [v2]

Jan Kratochvil duke at openjdk.org
Wed Mar 1 11:59:07 UTC 2023


On Mon, 27 Feb 2023 02:23:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   8302191: Performance degradation for float/double modulo on Linux
>
> src/hotspot/cpu/x86/sharedRuntime_x86.cpp line 97:
> 
>> 95: jne    1b        \n\
>> 96: "
>> 97:     :"=t"(retval)
> 
> This doesn't compile on Windows
> 
>  c:\sb\prod\1677461706\workspace\open\src\hotspot\cpu\x86\sharedRuntime_x86.cpp(97): error C2059: syntax error: ':'
> c:\sb\prod\1677461706\workspace\open\src\hotspot\cpu\x86\sharedRuntime_x86.cpp(114): error C2059: syntax error: ':'
> 
> I assume this asm is gcc based.

Thanks for reporting it, I am no longer providing the asm variant on any Windows platform.

-------------

PR: https://git.openjdk.org/jdk/pull/12508


More information about the hotspot-dev mailing list