RFR: 8302191: Performance degradation for float/double modulo on Linux [v5]

David Holmes dholmes at openjdk.org
Thu Mar 2 04:05:15 UTC 2023


On Wed, 1 Mar 2023 12:03:54 GMT, Jan Kratochvil <duke at openjdk.org> wrote:

>> I have OCA already processed/approved. I am not Author but my Author request is being processed these days (sent to Rob McKenna).
>> I did regression test x86_64 OpenJDK-8. I will leave other regression testing on GHA.
>> The patch (and former GCC performance regression) affects only x86_64+i686.
>
> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix copyright author.

You can't move the _WIN64 workaround to the sharedRuntime_x86.cpp file as that code is also used by Windows-Aarch64. Whether it needs the workaround or not is another matter, but unless proven otherwise we have to assume it does.

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12508


More information about the hotspot-dev mailing list