Integrated: 8303418: Improve parameter and variable names in BitMap
Kim Barrett
kbarrett at openjdk.org
Thu Mar 2 09:49:15 UTC 2023
On Wed, 1 Mar 2023 04:39:19 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review this change to names in BitMap.
>
> - Parameters that designate a bit in a BitMap are named "bit".
> - Parameters that designate a word in the underlying BitMap storage are named "word".
> - Parameters that designate a range are named "beg" and "end" resp.
>
> Added helper function `flipped_word` for use by `get_next_bit_impl`, replacing
> the odd overload for `map`.
>
> In `get_next_bit_impl`, prefixed the variables "index" and "limit" with
> "word_" to make clear the units.
>
> Testing:
> mach5 tier1
This pull request has now been integrated.
Changeset: 3091744f
Author: Kim Barrett <kbarrett at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/3091744fff56ae08861f28b87c1de27738c4c62b
Stats: 55 lines in 3 files changed: 5 ins; 1 del; 49 mod
8303418: Improve parameter and variable names in BitMap
Reviewed-by: tschatzl, aboldtch
-------------
PR: https://git.openjdk.org/jdk/pull/12798
More information about the hotspot-dev
mailing list