RFR: JDK-8302989: Add missing INCLUDE_CDS checks [v3]

Matthias Baesken mbaesken at openjdk.org
Thu Mar 2 16:27:32 UTC 2023


> The cds only coding in hotspot is usually guarded with the INCLUDE_CDS macro so that it can be removed at compile time in case the correct configure flags are set.
> However at some places INCLUDE_CDS is missing and should be added.
> 
> One question - should (additionally to the UseSharedSpaces code section)  the DumpSharedSpaces code sections be guarded as well with INCLUDE_CDS macros ?

Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:

  adjust some cds related vars

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12691/files
  - new: https://git.openjdk.org/jdk/pull/12691/files/5dff9614..33eb5631

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12691&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12691&range=01-02

  Stats: 18 lines in 2 files changed: 2 ins; 14 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/12691.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12691/head:pull/12691

PR: https://git.openjdk.org/jdk/pull/12691


More information about the hotspot-dev mailing list