RFR: 8302780: Add support for vectorized arraycopy GC barriers [v8]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Mon Mar 6 08:42:31 UTC 2023
On Thu, 2 Mar 2023 10:02:59 GMT, Andrew Haley <aph at openjdk.org> wrote:
> > In my opinion, the (very much needed) changes you suggest are outside the scope of this PR, which is about lifting the memory accesses, in their existing form, to a barrier API-level. Conflating this with your suggested changes would make it harder to review this PR, which is sufficiently complex in its current form. I totally agree that your suggestions would improve readability and maintainability, but couldn't we apply them in a follow-up RFE?
>
> I disagree in every way. The added complexity, which is fixed so it no longer matters, made it near-impossible for me to reason about this PR. And, as John Rose put it, like any good carpenter we should clean up as we work.
Just to be clear, my comment was specifically about the loop re-rolling part of your suggestions. I see now that this was not clear in my comment, sorry about that.
-------------
PR: https://git.openjdk.org/jdk/pull/12670
More information about the hotspot-dev
mailing list