RFR: 8292059: Do not inline InstanceKlass::allocate_instance() [v2]

[Stefan Karlsson]

On Fri, 3 Mar 2023 11:53:48 GMT, Afshin Zafari <duke at openjdk.org> wrote:

>> The inline and not-inline versions of the method is stress tested to compare the performance difference. The statistics are drawn in the following charts. The vertical axis is in milliseconds.
>> 
>> ![chart (2)](https://user-images.githubusercontent.com/4697012/221848555-2884313e-9d26-41c9-a265-3f1ce295b17b.png)
>> 
>> ![chart (3)](https://user-images.githubusercontent.com/4697012/221863810-94118677-b4af-468f-90c6-5ea365ae3588.png)
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8292059: Do not inline InstanceKlass::allocate_instance()

There's a lot of changes to includes that needs to be restored / cleaned. I've marked them below:

src/hotspot/share/memory/iterator.inline.hpp line 35:

> 33: #include "oops/compressedOops.inline.hpp"
> 34: #include "oops/klass.hpp"
> 35: #include "utilities/devirtualizer.inline.hpp"

Sort order is wrong.

src/hotspot/share/oops/instanceKlass.inline.hpp line 28:

> 26: #define SHARE_OOPS_INSTANCEKLASS_INLINE_HPP
> 27: 
> 28: #include "oops/instanceKlass.hpp"

All these includes should *not* be removed.

src/hotspot/share/oops/oop.inline.hpp line 36:

> 34: #include "oops/arrayOop.hpp"
> 35: #include "oops/compressedOops.inline.hpp"
> 36: #include "oops/klass.inline.hpp"

Sort order.

src/hotspot/share/prims/jvmtiEnvBase.cpp line 28:

> 26: #include "classfile/classLoaderDataGraph.hpp"
> 27: #include "classfile/javaClasses.inline.hpp"
> 28: #include "classfile/vmSymbols.hpp"

Sort order.

-------------

Changes requested by stefank (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12782