RFR: 8292059: Do not inline InstanceKlass::allocate_instance() [v2]

Stefan Karlsson stefank at openjdk.org
Mon Mar 6 13:39:19 UTC 2023


On Fri, 3 Mar 2023 11:53:48 GMT, Afshin Zafari <duke at openjdk.org> wrote:

>> The inline and not-inline versions of the method is stress tested to compare the performance difference. The statistics are drawn in the following charts. The vertical axis is in milliseconds.
>> 
>> ![chart (2)](https://user-images.githubusercontent.com/4697012/221848555-2884313e-9d26-41c9-a265-3f1ce295b17b.png)
>> 
>> ![chart (3)](https://user-images.githubusercontent.com/4697012/221863810-94118677-b4af-468f-90c6-5ea365ae3588.png)
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8292059: Do not inline InstanceKlass::allocate_instance()

What is the motivation to change the parameter from `oop java_class` to `InstanceKlass*`? The call sites are now much noisier and harder to read.

-------------

PR: https://git.openjdk.org/jdk/pull/12782


More information about the hotspot-dev mailing list