RFR: 8302191: Performance degradation for float/double modulo on Linux [v10]

[David Holmes]

On Sat, 4 Mar 2023 02:28:43 GMT, Jan Kratochvil <duke at openjdk.org> wrote:

>> I have OCA already processed/approved. I am not Author but my Author request is being processed these days (sent to Rob McKenna).
>> I did regression test x86_64 OpenJDK-8. I will leave other regression testing on GHA.
>> The patch (and former GCC performance regression) affects only x86_64+i686.
>
> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix win32 broken build.

Changes requested by dholmes (Reviewer).

src/hotspot/share/runtime/sharedRuntime.cpp line 238:

> 236: #endif
> 237: 
> 238: #if !defined(TARGET_COMPILER_gcc) || defined(_WIN64)

That is the wrong condition - it would activate for any non-Windows, non-gcc compiler. This code is only for _WIN64 is it not? regardless of the (theoretical) compiler used on win64?

src/hotspot/share/runtime/sharedRuntime.cpp line 272:

> 270: #endif
> 271: JRT_END
> 272: #endif // !X86 || _WIN64

!X86 ???

-------------

PR: https://git.openjdk.org/jdk/pull/12508