RFR: 8302191: Performance degradation for float/double modulo on Linux [v10]

David Holmes dholmes at openjdk.org
Tue Mar 7 12:18:06 UTC 2023


On Tue, 7 Mar 2023 08:47:21 GMT, Jan Kratochvil <duke at openjdk.org> wrote:

>> src/hotspot/share/runtime/sharedRuntime.cpp line 238:
>> 
>>> 236: #endif
>>> 237: 
>>> 238: #if !defined(TARGET_COMPILER_gcc) || defined(_WIN64)
>> 
>> That is the wrong condition - it would activate for any non-Windows, non-gcc compiler. This code is only for _WIN64 is it not? regardless of the (theoretical) compiler used on win64?
>
> For non-Windows non-gcc compiler it will use:
>>   return ((jfloat)fmod((double)x,(double)y));
> 
> Which I find correct.

Sorry my mistake.

-------------

PR: https://git.openjdk.org/jdk/pull/12508


More information about the hotspot-dev mailing list