RFR: JDK-8302989: Add missing INCLUDE_CDS checks [v4]

[Matthias Baesken]

On Fri, 3 Mar 2023 08:55:07 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> The cds only coding in hotspot is usually guarded with the INCLUDE_CDS macro so that it can be removed at compile time in case the correct configure flags are set.
>> However at some places INCLUDE_CDS is missing and should be added.
>> 
>> One question - should (additionally to the UseSharedSpaces code section)  the DumpSharedSpaces code sections be guarded as well with INCLUDE_CDS macros ?
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust arguments handling

Unfortunately with the latest revision of the patch, quite a few tests fail when the build is configured with `--disable-cds`  .
Seems those tests set various -Xshare options for some reason, especially  `-Xshare:off`  .

Failing tests (there might be a few more where the reason is not fully clear from the log)
jdk/jfr/event/runtime/TestMetaspaceAllocationFailure.java
Unrecognized option: -Xshare:off

sun/security/provider/X509Factory/BigCRL.java
Unrecognized option: -Xshare:off

java/lang/module/ModuleDescriptorHashCodeTest.java
Unrecognized option: -Xshare:off

java/math/BigInteger/largeMemory/DivisionOverflow.java
Unrecognized option: -Xshare:off

java/math/BigInteger/largeMemory/StringConstructorOverflow.java
Unrecognized option: -Xshare:off

runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java#id7
stderr content[Unrecognized option: -Xshare:dump

runtime/7158988/FieldMonitor.java
JavaTest Message: Test threw exception: java.lang.Error: Target VM failed to initialize: VM initialization failed for:

-------------

PR: https://git.openjdk.org/jdk/pull/12691