RFR: 8302491: NoClassDefFoundError omits the original cause of an error [v4]

Ilarion Nakonechnyy inakonechnyy at openjdk.org
Tue Mar 7 23:54:13 UTC 2023


On Tue, 7 Mar 2023 02:03:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ilarion Nakonechnyy has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - reverting changes in cpCache.cpp
>>  - Redesigned get_cause as create_initialization_error.
>>    Corrected naming in testcase
>>  - jcheck corrections
>>  - Removed VM.compMode from test
>
> src/hotspot/share/oops/instanceKlass.cpp line 987:
> 
>> 985:   MutexLocker ml(THREAD, ClassInitError_lock);
>> 986:   OopHandle elem = OopHandle(Universe::vm_global(), cause());
>> 987:   bool created;
> 
> We still need to return if we got null.

Thanks, I was mistaken  about my corrections in calling `JavaCalls::call_virtual(`, and thought that create_initialization_error always return a non-null handle()

-------------

PR: https://git.openjdk.org/jdk/pull/12566


More information about the hotspot-dev mailing list