RFR: JDK-8302989: Add missing INCLUDE_CDS checks [v4]

[Ioi Lam]

On Fri, 3 Mar 2023 08:55:07 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> The cds only coding in hotspot is usually guarded with the INCLUDE_CDS macro so that it can be removed at compile time in case the correct configure flags are set.
>> However at some places INCLUDE_CDS is missing and should be added.
>> 
>> One question - should (additionally to the UseSharedSpaces code section)  the DumpSharedSpaces code sections be guarded as well with INCLUDE_CDS macros ?
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust arguments handling

Maybe we can keep the -Xshare flags and make their behavior consistent with builds that have CDS enabled:

-Xshare:off  - do nothing 
-Xshare:auto - do nothing (CDS cannot be used so it’s “automatically” disabled)
-Xshare:on - fail and report that CDS archive cannot be loaded.

-------------

PR: https://git.openjdk.org/jdk/pull/12691