RFR: JDK-8302989: Add missing INCLUDE_CDS checks [v4]
Matthias Baesken
mbaesken at openjdk.org
Wed Mar 8 14:59:25 UTC 2023
On Fri, 3 Mar 2023 08:55:07 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> The cds only coding in hotspot is usually guarded with the INCLUDE_CDS macro so that it can be removed at compile time in case the correct configure flags are set.
>> However at some places INCLUDE_CDS is missing and should be added.
>>
>> One question - should (additionally to the UseSharedSpaces code section) the DumpSharedSpaces code sections be guarded as well with INCLUDE_CDS macros ?
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Adjust arguments handling
The disabling/enabling of jvm features is briefly mentioned in the build doc ( https://openjdk.org/groups/build/doc/building.html ) so I thought this is something that is supported and should work (maybe not perfect because of limited testing) . If it is really not so interesting to others to adjust tests with `@requires vm.cds` where needed and to remove not needed code when the feature is disabled , then we can leave it as it is.
-------------
PR: https://git.openjdk.org/jdk/pull/12691
More information about the hotspot-dev
mailing list