RFR: 8302191: Performance degradation for float/double modulo on Linux [v11]

Sandhya Viswanathan sviswanathan at openjdk.org
Thu Mar 9 18:55:57 UTC 2023


On Tue, 7 Mar 2023 08:51:53 GMT, Jan Kratochvil <duke at openjdk.org> wrote:

>> I have OCA already processed/approved. I am not Author but my Author request is being processed these days (sent to Rob McKenna).
>> I did regression test x86_64 OpenJDK-8. I will leave other regression testing on GHA.
>> The patch (and former GCC performance regression) affects only x86_64+i686.
>
> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - Fix #endif comment - found by dholmes-ora.
>  - Merge branch 'master' into modulo
>  - Fix win32 broken build.
>  - Merge remote-tracking branch 'origin/master' into modulo
>  - Always include the _WIN64 workaround - a review by dholmes-ora.
>  - Remove comments to be moved to JBS (Bug System) - a review by jddarcy.
>  - Uppercase L - a review by turbanoff.
>  - Fix copyright author.
>  - Fix WIN32 vs. WIN64.
>  - Update according to the upstream review by David Holmes.
>  - ... and 1 more: https://git.openjdk.org/jdk/compare/285b0bd1...e4ff04dc

src/hotspot/share/runtime/sharedRuntime.cpp line 238:

> 236: #endif
> 237: 
> 238: #if !defined(TARGET_COMPILER_gcc) || defined(_WIN64)

The aarch64 and other builds are now broken with missing SharedRuntime::frem and SharedRuntime::drem.

-------------

PR: https://git.openjdk.org/jdk/pull/12508


More information about the hotspot-dev mailing list