RFR: JDK-8303861: Error handling step timeouts should never be blocked by OnError and others [v2]

[Thomas Stuefe]

On Fri, 10 Mar 2023 06:27:28 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   limit step timeout to 5 seconds max
>
> src/hotspot/share/runtime/nonJavaThread.cpp line 274:
> 
>> 272: 
>> 273:         // Wait a second, then recheck for timeout.
>> 274:         os::naked_short_sleep(999);
> 
> Harmless change but I don't see why we need sub-second resolution when the ErrorLogTimeout is in seconds. ??

This matters because it also applies to each step timeout too. If we check only once per second, we overshoot each timeout by up to one second. This overshooting happens for every step timeout. If we are in a situation like here where we ignore the global step timeout, and we keep running into deadlocks e.g. in malloc, we will encounter a lot of step timeouts; these would add up.

-------------

PR: https://git.openjdk.org/jdk/pull/12936