RFR: JDK-8303861: Error handling step timeouts should never be blocked by OnError and others [v2]

[Thomas Stuefe]

On Fri, 10 Mar 2023 12:09:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Note that this matters even more in the context of https://github.com/openjdk/jdk/pull/11017, since that will increase the granularity for each error reporting step, potentially exposing us to a lot more individual timeouts.
>
> I thought there was a limit of three step timeouts before we gave up? And the step timeout is a quarter of the global so still many seconds.

There is no such limit. There is an implicit limit of 4 step timeouts since step timeout time was 1/4th of ErrorLogTimeout. But 
- that does not apply if we ignore ErrorLogTimeout
- in this patch, I curtailed the maximum step timeout time to 5 seconds (see https://github.com/openjdk/jdk/blob/70b9add7685b3424ac3fee55597d470aa76c8b1b/src/hotspot/share/utilities/vmError.cpp#L1807-L1809), exactly to prevent it from growing very large for very large ErrorLogTimeouts.

So, with my patch: Each step timeout is either ErrorLogTimeout/4 or 5 seconds, whatever is shorter. While writing this, I noted that this also holds true if we then go and ignore ErrorLogTimeout. Should I then just use 5 seconds? Not sure.

-------------

PR: https://git.openjdk.org/jdk/pull/12936