RFR: 8292059: Do not inline InstanceKlass::allocate_instance() [v3]
Afshin Zafari
duke at openjdk.org
Fri Mar 10 17:15:54 UTC 2023
On Thu, 9 Mar 2023 11:07:57 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8292059: Do not inline InstanceKlass::allocate_instance()
>
> src/hotspot/share/prims/jni.cpp line 967:
>
>> 965:
>> 966: instanceOop i = InstanceKlass::allocate_instance(
>> 967: InstanceKlass::cast(java_lang_Class::as_Klass(JNIHandles::resolve_non_null(clazz))),
>
> Perhaps it would be nice with a utility method to reduce some of the clutter. Just folding the `as_Klass` into a new method `instanceKlass::cast_from_oop(..)` (or just `from_oop`) would cut away a fair chunk and could be used to similar effect elsewhere (counting 21 cases where this would be applicable).
An specific RFE is created for this parameter change. The change is reverted and not in this PR anymore.
-------------
PR: https://git.openjdk.org/jdk/pull/12782
More information about the hotspot-dev
mailing list