RFR: JDK-8303861: Error handling step timeouts should never be blocked by OnError and others [v2]
Thomas Stuefe
stuefe at openjdk.org
Sat Mar 11 16:37:24 UTC 2023
On Fri, 10 Mar 2023 14:54:20 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> limit step timeout to 5 seconds max
>
> src/hotspot/share/utilities/vmError.cpp line 1787:
>
>> 1785: // Global timeout hit?
>> 1786: if (!ignore_global_timeout) {
>> 1787: const jlong reporting_start_time_l = get_reporting_start_time();
>
> What is the meaning of _l here? Is it to indicate the type of the variable? If so, I would suggest to remove it. (I know it is pre-existing. I leave this up to you.)
This is a remnant of the old implementation. I'll change it.
-------------
PR: https://git.openjdk.org/jdk/pull/12936
More information about the hotspot-dev
mailing list