RFR: 8301244: Tidy up compiler specific warnings files [v9]

Kim Barrett kbarrett at openjdk.org
Sat Mar 11 17:17:11 UTC 2023


On Sat, 11 Mar 2023 14:55:56 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Cleans up some code in compilerWarnings_*.hpp files to be slightly neater
>
> Julian Waters has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - compilerWarnings_visCPP.hpp
>  - Spelling
>  - compilerWarnings_gcc.hpp
>  - macros.hpp

Changes requested by kbarrett (Reviewer).

src/hotspot/share/utilities/compilerWarnings_gcc.hpp line 37:

> 35: #endif
> 36: 
> 37: #define PRAGMA_DISABLE_GCC_WARNING(option) _Pragma(STR(GCC diagnostic ignored option))

s/option/option_string/ as before, to make it a little more obvious that the argument is a string literal.

-------------

PR: https://git.openjdk.org/jdk/pull/12255


More information about the hotspot-dev mailing list