RFR: 8302191: Performance degradation for float/double modulo on Linux [v11]

Sun Mar 12 13:21:21 UTC 2023

On Thu, 9 Mar 2023 18:53:13 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Fix #endif comment - found by dholmes-ora.
>>  - Merge branch 'master' into modulo
>>  - Fix win32 broken build.
>>  - Merge remote-tracking branch 'origin/master' into modulo
>>  - Always include the _WIN64 workaround - a review by dholmes-ora.
>>  - Remove comments to be moved to JBS (Bug System) - a review by jddarcy.
>>  - Uppercase L - a review by turbanoff.
>>  - Fix copyright author.
>>  - Fix WIN32 vs. WIN64.
>>  - Update according to the upstream review by David Holmes.
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/f101d786...e4ff04dc
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 238:
> 
>> 236: #endif
>> 237: 
>> 238: #if !defined(TARGET_COMPILER_gcc) || defined(_WIN64)
> 
> The aarch64 and other builds are now broken with missing SharedRuntime::frem and SharedRuntime::drem.

True, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/12508