RFR: 8292059: Do not inline InstanceKlass::allocate_instance() [v5]

Stefan Karlsson stefank at openjdk.org
Mon Mar 13 06:38:29 UTC 2023


On Sat, 11 Mar 2023 16:31:06 GMT, Afshin Zafari <duke at openjdk.org> wrote:

>> The inline and not-inline versions of the method is tested to compare the performance difference. 
>> ### Test
>> `make test TEST=micro:Capture0.lambda_01 MICRO="VM_OPTIONS=-XX:TieredStopAtLevel=1" `
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8292059: Do not inline InstanceKlass::allocate_instance()

Changes requested by stefank (Reviewer).

src/hotspot/share/oops/oop.inline.hpp line 37:

> 35: #include "oops/compressedOops.inline.hpp"
> 36: #include "oops/instanceKlass.hpp"
> 37: #include "oops/klass.inline.hpp"

I don't see anything in oop.inline.hpp that needs klass.inline.hpp.

src/hotspot/share/prims/jni.cpp line 61:

> 59: #include "oops/instanceKlass.inline.hpp"
> 60: #include "oops/instanceOop.hpp"
> 61: #include "oops/klass.inline.hpp"

jni.cpp uses klass.inline.hpp, so this line needs to stay.

-------------

PR: https://git.openjdk.org/jdk/pull/12782


More information about the hotspot-dev mailing list