RFR: 8302191: Performance degradation for float/double modulo on Linux [v12]

Sandhya Viswanathan sviswanathan at openjdk.org
Mon Mar 13 16:14:30 UTC 2023


On Sun, 12 Mar 2023 13:21:18 GMT, Jan Kratochvil <duke at openjdk.org> wrote:

>> I have OCA already processed/approved. I am not Author but my Author request is being processed these days (sent to Rob McKenna).
>> I did regression test x86_64 OpenJDK-8. I will leave other regression testing on GHA.
>> The patch (and former GCC performance regression) affects only x86_64+i686.
>
> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
> 
>  - Fix missing SharedRuntime::frem and SharedRuntime::drem on aarch64.
>     - bugreported by sviswa7.
>  - Merge branch 'master' into modulo
>  - Fix #endif comment - found by dholmes-ora.
>  - Merge branch 'master' into modulo
>  - Fix win32 broken build.
>  - Merge remote-tracking branch 'origin/master' into modulo
>  - Always include the _WIN64 workaround - a review by dholmes-ora.
>  - Remove comments to be moved to JBS (Bug System) - a review by jddarcy.
>  - Uppercase L - a review by turbanoff.
>  - Fix copyright author.
>  - ... and 3 more: https://git.openjdk.org/jdk/compare/37d28306...f03d4cdf

Looks good to me.

-------------

Marked as reviewed by sviswanathan (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12508


More information about the hotspot-dev mailing list