RFR: 8301308: Remove version conditionalization for gcc/clang PRAGMA_DIAG_PUSH/POP

[Kim Barrett]

On Tue, 14 Mar 2023 17:51:12 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> As of now we at minimum require clang 3.5 and gcc 6 to compile the Java Platform, the version checks for gcc/clang here are for whether clang is either version 4 and above, or has a minor version higher than 3.1, and for gcc either a major version higher than 4 or minor version above 4.6. Now these will always pass, so they can be removed. Also changes the macro definition location to match Visual C++ and look neater

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.org/jdk/pull/13025