RFR: 8303150: DCmd framework unnecessarily creates a DCmd instance on registration [v2]

[David Holmes]

On Wed, 15 Mar 2023 10:36:14 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Comment update - Kevin's feedback
>
> Took me a bit of time, as I was thinking if we compare a hard-coded value with a parsed argument count, how does that cope with optional arguments?  Maybe "get_parsed_num_arguments()" suggested to me it was a live command being parsed, but DCmdParser's _arguments_list is a list of known possible arguments. Should have read your "number of arguments taken by the DCmd" at the top more carefully.

Thanks for the review @kevinjwalls .

-------------

PR: https://git.openjdk.org/jdk/pull/12994