RFR: 8304089: Convert TraceDependencies to UL [v3]

Vladimir Ivanov vlivanov at openjdk.org
Tue Mar 21 17:12:03 UTC 2023


On Tue, 21 Mar 2023 13:24:03 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Hmmm this seems broken to me then. We output the general dependency logging to one place based on UL configuration, but then we output `log_dependency` to the log file. If these are meant to be related and always reported together then we have lost that. If they are actually unrelated then this may still need the TraceDependencies flag to control it.
>> 
>> @iwanowww can you comment on this please?
>
> Maybe we don't need this -Xlog test in this place, because this is also what PrintDependencies does.

Yes, UL check doesn't help here. Irrespective of the check, UL output isn't automatically placed in VM log.
It's convenient for LogCompilation to have VM output along with other VM events present in the log. 
Having said that, I'm fine with dropping TraceDependencies check here and improve the interaction between UL and LogVMOutput separately.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13007#discussion_r1143727768


More information about the hotspot-dev mailing list