RFR: 8301995: Move invokedynamic resolution information out of ConstantPoolCacheEntry [v9]

Tue Mar 21 17:43:57 UTC 2023

On Tue, 21 Mar 2023 10:49:32 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix riscv interpreter mistake and acquire semantics
>
> src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 2337:
> 
>> 2335:   // Load-acquire the adapter method
>> 2336:   __ lea(method, Address(cache, in_bytes(ResolvedIndyEntry::method_offset())));
>> 2337:   __ ldar(method, method);
> 
> What reordering are we trying to prevent here?

The loads of the data stored in `ResolvedIndyEntry::fill_in()` must not be reordered with loading  `ResolvedIndyEntry::_method`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12778#discussion_r1143781928