RFR: 8231349: Move intrinsic stubs generation to compiler runtime initialization code [v2]

Vladimir Kozlov kvn at openjdk.org
Wed Mar 22 22:21:41 UTC 2023


On Wed, 22 Mar 2023 21:40:25 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address Claes comments
>
> src/hotspot/cpu/ppc/stubGenerator_ppc.cpp line 4778:
> 
>> 4776: 
>> 4777:  public:
>> 4778:   StubGenerator(CodeBuffer* code, StubsKind kind) : StubCodeGenerator(code) {
> 
> The code is repeated on multiple platforms. It makes sense to lift it to `StubCodeGenerator`.

It is because `StubGenerator` is declared and defined separately on each platform. Doing that here will add more complexity for already not small changes.  Filed new RFE: [JDK-8304750](https://bugs.openjdk.org/browse/JDK-8304750)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13096#discussion_r1145465531


More information about the hotspot-dev mailing list